[r8] Apply pylint excessive memory usage fix #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On our github runner I built a new container from this branch. The tests are now already running with the new one. Memory usage is now a bit more reasonable, and with four jobs the test is also faster: See also my recent follow-up to pylint-dev/pylint#1495 (comment) |
martinpitt
changed the title
With current astroid 2.4.2, pylint requires a ginormous amount of memory. Apply the recent fix during container build, until a newer version gets released. Revert the hack from commit 2835615 and go back to pylint auto-selecting the number of jobs based on number of CPUs. Backported from master PR rhinstaller#3018 Related: rhbz#1885635
martinpitt
force-pushed
the
r8-pylint-mem-fix
branch
from
256b0e4
to
c7ece9b
Compare
|
Argh, forgot the magic "Related #rhbz#, and I also added a reference to PR #3018 (the corresponding master PR) |
That could be a nice workflow check on PR for rhel-8 branch really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current astroid 2.4.2, pylint requires a ginormous amount of
memory. Apply the recent fix during container build, until a newer
version gets released.
Revert the hack from commit 2835615 and go back to pylint
auto-selecting the number of jobs based on number of CPUs.
Backported from master PR #3018
Related: rhbz#1885635