Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: handle wireless configure button sensitiveness #3098

Conversation

rvykydal
Copy link
Contributor

When configuring a wireless device (clicking Configure button) without any
access point selected before (by clicking Select network) we used to present
the dialog with empty list of access points. With the patch make the Configure
button sensitive only if there already is some access point to be selected.

Resolves: rhbz#1917437

@rvykydal rvykydal added the master Please, use the `f39` label instead. label Jan 19, 2021
@rvykydal rvykydal added the notable change Important changes like API change, behavior change... label Jan 19, 2021
@rvykydal
Copy link
Contributor Author

kickstart --testtype smoke

When configuring a wireless device (clicking Configure button) without any
access point selected before (by clicking Select network) we used to present
the dialog with empty list of access points. With the patch make the Configure
button sensitive only if there already is some access point to be selected.

Resolves: rhbz#1917437
@rvykydal rvykydal force-pushed the port-3067-improve-wireless-device-configuration-gui branch from 0be54d3 to 29929b6 Compare January 19, 2021 11:28
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal rvykydal merged commit f08a0fd into rhinstaller:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead. notable change Important changes like API change, behavior change...
2 participants