-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: do not use dialog for just single wireless connection to con… #3009
network: do not use dialog for just single wireless connection to con… #3009
Conversation
956cb0e
to
60ee0ed
Compare
…figure Related: rhbz#1847681
Show dialog for network selection only if we have multiple profiles: If there is only single connection, edit it right away: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm a bit late, but I found it confusing to allow to click the "Configure..." button if there is nothing to be configured. (https://rvykydal.fedorapeople.org/new_ui_configure_single_con.webm). Shouldn't the button be disabled if the list of networks to configure is empty? |
I will add this in another PR when NM crashes which would make the configuration with this addition even more fragile are fixed (https://bugzilla.redhat.com/show_bug.cgi?id=1873561) |
|
…figure
Follow up to #2977