Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: do not use dialog for just single wireless connection to con… #3009

Conversation

rvykydal
Copy link
Contributor

…figure

Follow up to #2977

@rvykydal rvykydal added the master Please, use the `f39` label instead. label Nov 20, 2020
@rvykydal rvykydal force-pushed the network-wireless-configuration-dialog-shortcut branch from 956cb0e to 60ee0ed Compare November 20, 2020 13:10
@rvykydal
Copy link
Contributor Author

Show dialog for network selection only if we have multiple profiles:
https://rvykydal.fedorapeople.org/new_ui_configure_more_cons_available.webm

If there is only single connection, edit it right away:
https://rvykydal.fedorapeople.org/new_ui_configure_single_con.webm
... The connection is created when selecting the network and in this case entering wrong password. Typical use case is WPA Enterprise where we don't ask for credentials in secret agent dialog when selecting the network (too complex), but we just create the connection and let the user enter credentials via configuration using nm-c-e.

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rvykydal rvykydal merged commit 5c75dad into rhinstaller:master Nov 24, 2020
@jstodola
Copy link
Contributor

I'm a bit late, but I found it confusing to allow to click the "Configure..." button if there is nothing to be configured. (https://rvykydal.fedorapeople.org/new_ui_configure_single_con.webm). Shouldn't the button be disabled if the list of networks to configure is empty?

@rvykydal
Copy link
Contributor Author

rvykydal commented Dec 8, 2020

I'm a bit late, but I found it confusing to allow to click the "Configure..." button if there is nothing to be configured. (https://rvykydal.fedorapeople.org/new_ui_configure_single_con.webm). Shouldn't the button be disabled if the list of networks to configure is empty?

I will add this in another PR when NM crashes which would make the configuration with this addition even more fragile are fixed (https://bugzilla.redhat.com/show_bug.cgi?id=1873561)

@rvykydal
Copy link
Contributor Author

I'm a bit late, but I found it confusing to allow to click the "Configure..." button if there is nothing to be configured. (https://rvykydal.fedorapeople.org/new_ui_configure_single_con.webm). Shouldn't the button be disabled if the list of networks to configure is empty?

I will add this in another PR when NM crashes which would make the configuration with this addition even more fragile are fixed (https://bugzilla.redhat.com/show_bug.cgi?id=1873561)

#3098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
Development

Successfully merging this pull request may close these issues.

4 participants