-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove authconfig support #3500
Conversation
Authconfig compatibility tool (from authselect-compat) will be removed from Fedora 35: https://fedoraproject.org/wiki/Changes/RemoveAuthselectCompatPackage
/kickstart-test --testtype smoke |
CI failed with |
/kickstart-test --testtype security |
Yes, the tests are expected to do that, you will have to change them too. |
The kickstart tests all succeeded, except for authconfig which must fail. I think that's a success. (Recording here because these results will disappear, once the fixed unit tests are force-pushed.) |
Can you give me any hint how to update the failing test? I don't know where the 'auth' keyword is comming from. |
@pbrezina, the tests require a new pykickstart with the related changes. I will test it locally today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code was tested locally. The changes look good to me. Thank you!
Authconfig compatibility tool (from authselect-compat) will be removed from Fedora 35:
https://fedoraproject.org/wiki/Changes/RemoveAuthselectCompatPackage