Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove authconfig support #3500

Merged
merged 1 commit into from
Jul 15, 2021
Merged

remove authconfig support #3500

merged 1 commit into from
Jul 15, 2021

Conversation

pbrezina
Copy link
Contributor

@pbrezina pbrezina commented Jul 9, 2021

Authconfig compatibility tool (from authselect-compat) will be removed from Fedora 35:
https://fedoraproject.org/wiki/Changes/RemoveAuthselectCompatPackage

Authconfig compatibility tool (from authselect-compat) will be removed from Fedora 35:
https://fedoraproject.org/wiki/Changes/RemoveAuthselectCompatPackage
@poncovka poncovka self-assigned this Jul 9, 2021
@poncovka
Copy link
Contributor

poncovka commented Jul 9, 2021

/kickstart-test --testtype smoke

@poncovka poncovka added manual testing required This issue can't be merged without manual testing master Please, use the `f39` label instead. labels Jul 9, 2021
@pbrezina
Copy link
Contributor Author

CI failed with test_useless_command_map is it correct to remove these commands like this (by removing the code) or should I do it differently?

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype security

@VladimirSlavik
Copy link
Contributor

CI failed with test_useless_command_map is it correct to remove these commands like this (by removing the code) or should I do it differently?

Yes, the tests are expected to do that, you will have to change them too.

@VladimirSlavik
Copy link
Contributor

The kickstart tests all succeeded, except for authconfig which must fail. I think that's a success.

(Recording here because these results will disappear, once the fixed unit tests are force-pushed.)

@pbrezina
Copy link
Contributor Author

Can you give me any hint how to update the failing test? I don't know where the 'auth' keyword is comming from.

@poncovka
Copy link
Contributor

@pbrezina, the tests require a new pykickstart with the related changes. I will test it locally today.

@poncovka poncovka removed the manual testing required This issue can't be merged without manual testing label Jul 15, 2021
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was tested locally. The changes look good to me. Thank you!

@poncovka poncovka merged commit 203cf46 into rhinstaller:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
Development

Successfully merging this pull request may close these issues.

3 participants