Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests for python 3.11 #4216

Merged

Conversation

VladimirSlavik
Copy link
Contributor

@VladimirSlavik VladimirSlavik commented Jun 27, 2022

With this, unit tests can succeed.

Pylint is not fixed - its most current breakage is due to interface changes in the new Python disagreeing with dill, whatever that is. See uqfoundation/dill#514 and uqfoundation/dill#480. Note that this PR does not change anything requiring rebuild of containers, so pylint appears to work here, but it's just stale container being used.

@VladimirSlavik VladimirSlavik added the f37 Fedora 37 label Jun 27, 2022
@VladimirSlavik
Copy link
Contributor Author

VladimirSlavik commented Jun 27, 2022

@hroncok, if you can please take a look, I would be grateful. I'll admit I don't really understand the "why" of this, just that eliminating some of the self made it work.

If by chance you have any ideas about pylint/dill, I'm all ears too. My understanding is that we are waiting for their release that is compatible with the Python betas.

@VladimirSlavik
Copy link
Contributor Author

/kickstart-test --testtype smoke

@VladimirSlavik VladimirSlavik added the infrastructure Changes affecting mostly infrastructure label Jun 27, 2022
@hroncok
Copy link
Contributor

hroncok commented Jun 27, 2022

Is this by any chance an enum? That is a deliberate backward-incompatible change by the enum maintainer.

See for example:

python/cpython#87328
python/cpython#93910
python/steering-council#80

@hroncok
Copy link
Contributor

hroncok commented Jun 27, 2022

About pylint: I don't recommend running linters on not yet released Python versions.

@VladimirSlavik
Copy link
Contributor Author

VladimirSlavik commented Jun 27, 2022

Yes, it's an enum. Thank you for the information, as well as pushing to make this visible. (I did read the what's new pretty carefully...)

About pylint: I don't recommend running linters on not yet released Python versions.

Well, is it an option to just not take Rawhide's last Python? It doesn't feel that way from here.

It does not work well with Python 3.11.
@VladimirSlavik
Copy link
Contributor Author

/kickstart-test --testtype smoke

@hroncok
Copy link
Contributor

hroncok commented Jun 27, 2022

Well, is it an option to just not take Rawhide's last Python? It doesn't feel that way from here.

I don't know what are you doing (or trying to achieve), so I cannot answer your question.

  • If you try to cover multiple Python versions and install tools such as pylint via pip, you can use any Python version available on Rawhide to run the lint job.
  • If you try to cover multiple Fedora versions and you install tools such as pylint via official Fedora repos, I'd just not lint on Rawhide.

Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@VladimirSlavik VladimirSlavik merged commit 16bcf2f into rhinstaller:master Jun 28, 2022
@VladimirSlavik VladimirSlavik deleted the master-unittests-py311b1 branch June 28, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f37 Fedora 37 infrastructure Changes affecting mostly infrastructure
3 participants