simplify TestValues enum creation and usage

[ethanfurman]

Enhance #4216.

[VladimirSlavik]

Thank you! That looks a lot better, but the tests disagree, I'm afraid :-(

[ethanfurman]

Wow, it's actually embarassing how many times I forget to return member at the end of __new__.

It should work much better now. :-)

[VladimirSlavik]

Thank you, that looks great! Two things still:

• Do you think it would be better to explicitly have None as the value for the "broken" variants?
• Can you please squash this so that it's one commit? I can do that myself, if you want.

[ethanfurman]

Specifying None on the three broken variants is a matter of taste. I wouldn't usually do it myself, but I have no experience with your code base to know which is more consistent with its style.

As for squashing, feel free to do so as I have no idea how -- my git skills are fairly rudimentary.

[VladimirSlavik]

So, I squashed it and made the None explicit, so it's easier to get for the next generations. Your local branch is likely "broken" for you now, unless you delete it and pull from your fork.

[VladimirSlavik]

/kickstart-test --testtype smoke