Show multiple bootloader devices on the Manual Partitioning screen #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy-paste the `copy` method of the `Blivet` class, so we can later change it. It manipulates with collected installation roots, but these objects are part of Anaconda, not Blivet. Blivet should remove this code. Then we can call `super().copy()` to create a Blivet copy. (cherry picked from commit 4a437c3)
Define the `roots` attribute in Anaconda, so Blivet can remove it. (cherry picked from commit 2b6ed92)
Move the code for creating copies of installation roots to the `Root` class. Simplify the implementation, so it should be easier to change it later. (cherry picked from commit c6842bb)
Don't keep bootloader devices in a dictionary of mount points. Otherwise, we can loose information about bootloader devices of the same type (like biosboot) and show only one of them on the Manual Partitioning screen in GUI. All devices used by an OS installation are now represented by the `devices` property of the `OSData` structure. The list of devices includes bootloader devices, mount point sources and swap devices. The `swap_devices` property was removed. (cherry picked from commit 60a7960) Related: rhbz#2088113 Related: rhbz#2093793 Related: rhbz#1913035
Add unit tests for our redefinition of the Blivet.copy method. (cherry picked from commit 8b00e62)
|
/kickstart-test --testtype smoke |
VladimirSlavik
approved these changes
Sep 1, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't keep bootloader devices in a dictionary of mount points. Otherwise, we
can loose information about bootloader devices of the same type (like biosboot)
and show only one of them on the Manual Partitioning screen in GUI.
Related: rhbz#2088113
Ported from: #4271