New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated kickstart commands and options #5436
Remove deprecated kickstart commands and options #5436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks a lot! :)
This command was deprecated since Fedora 34. Resolves: INSTALLER-3849
f899f0d
to
03feed3
Compare
This command was deprecated since Fedora 34. Resolves: INSTALLER-3849
This option was deprecated since Fedora 34. Resolves: INSTALLER-3849
This option was deprecated since Fedora 33. Resolves: INSTALLER-3849
03feed3
to
add17cd
Compare
The future deprecation of these kickstart options was announced in Fedora 32 and 33. The support for these options was removed in the commit 51fcd02. Resolves: INSTALLER-3887
/kickstart-test --testtype smoke |
The unit tests pass if I run them with #5438. |
Blocked on: cockpit-project/bots#5860 |
Added commits from #5438 to verify that it will fix the tests. |
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Remove the following deprecated kickstart commands and options:
autostep
method
logging --level
repo --ignoregroups
Resolves: INSTALLER-3849
TODO:
Depends on: pykickstart/pykickstart#473