Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated kickstart commands and options #5436

Merged

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Jan 31, 2024

Remove the following deprecated kickstart commands and options:

  • autostep
  • method
  • logging --level
  • repo --ignoregroups

Resolves: INSTALLER-3849

TODO:

  • Test with the pykickstart changes.
  • Document in the release notes.

Depends on: pykickstart/pykickstart#473

@poncovka poncovka added blocked Don't merge this pull request! f40 labels Jan 31, 2024
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot! :)

This command was deprecated since Fedora 34.

Resolves: INSTALLER-3849
This command was deprecated since Fedora 34.

Resolves: INSTALLER-3849
This option was deprecated since Fedora 34.

Resolves: INSTALLER-3849
This option was deprecated since Fedora 33.

Resolves: INSTALLER-3849
The future deprecation of these kickstart options was announced in Fedora 32 and
33. The support for these options was removed in the commit 51fcd02.

Resolves: INSTALLER-3887
@poncovka poncovka removed the blocked Don't merge this pull request! label Feb 6, 2024
@poncovka
Copy link
Contributor Author

poncovka commented Feb 6, 2024

/kickstart-test --testtype smoke

@poncovka
Copy link
Contributor Author

poncovka commented Feb 6, 2024

The unit tests pass if I run them with #5438.

@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Feb 6, 2024
@KKoukiou
Copy link
Contributor

KKoukiou commented Feb 6, 2024

Blocked on: cockpit-project/bots#5860

@poncovka
Copy link
Contributor Author

poncovka commented Feb 6, 2024

Added commits from #5438 to verify that it will fix the tests.

@poncovka poncovka removed the blocked Don't merge this pull request! label Feb 6, 2024
@poncovka
Copy link
Contributor Author

poncovka commented Feb 6, 2024

/kickstart-test --testtype smoke

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@poncovka poncovka merged commit 5d78d87 into rhinstaller:master Feb 6, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants