Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate timezone --isUtc, --ntpservers and --nontp kickstart options #5438

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Jan 31, 2024

The future deprecation of these kickstart options was announced in Fedora 32 and
33. The support for these options was removed in the commit 51fcd02.

Resolves: INSTALLER-3887

TODO:

  • Test with the pykickstart changes.
  • Document in the release notes.

Depends on:

@poncovka poncovka added blocked Don't merge this pull request! f40 labels Jan 31, 2024
The future deprecation of these kickstart options was announced in Fedora 32 and
33. The support for these options was removed in the commit 51fcd02.

Resolves: INSTALLER-3887
@poncovka
Copy link
Contributor Author

poncovka commented Feb 6, 2024

/kickstart-test --testtype smoke

@poncovka
Copy link
Contributor Author

poncovka commented Feb 6, 2024

The unit tests pass if I run them with #5436.

@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Feb 6, 2024
@KKoukiou
Copy link
Contributor

KKoukiou commented Feb 6, 2024

Blocked on: cockpit-project/bots#5860

@poncovka poncovka removed the blocked Don't merge this pull request! label Feb 6, 2024
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@poncovka
Copy link
Contributor Author

poncovka commented Feb 6, 2024

Merged in #5436.

@poncovka poncovka closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants