Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude iso9660 disk in unused devices #5553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

exclude iso9660 disk in unused devices #5553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyanaconda/modules/storage/partitioning/interactive/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ def collect_unused_devices(storage):
and not d.partitioned
and (d.direct or d.isleaf)
and d not in used_devices
and d.format.type != "iso9660"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the purpose here to unmatch generally optical media?

Maybe using find_optical_media is the correct way?

@M4rtinK can you help with review please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that perhaps what we are seeing it actually a bug - if the media is used to start the installation, there should be code that puts it to the list of protected devices, which I would expect will prevent it from showing up at all. So maybe that is broken ?

BTW, it looks like iso9660 might be not just on optical media but also bootable installation flash drives, once you dd an installation image on them.

I guess there could be also the case of a user having two bootable installation flash drives connected, one used to boot to the installation and then another one just connected. Then the second one could show up as iso9660 volume & the question is how should Anaconda handle it ? I guess provide an option to delete the partition iso9660?

]

# Add incomplete VGs and MDs
Expand Down
Loading