Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude iso9660 disk in unused devices #5553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yueyuankun
Copy link

ISO version:Fedora-Server-dvd-aarch64-39-1.5.iso
use USB flash:dd if=Fedora-Server-dvd-aarch64-39-1.5.iso of=/dev/sdb

When I install the system on the hard drive, I select a custom partition and an unknown device appears in the spoke.
iso9660-1
And I was refused to remove this device.
iso9660-3
So let's exclude it from the unused device list.
After adding code:
iso9660-2

Copy link

We were not able to find or create Copr project packit/rhinstaller-anaconda-5553 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=rhinstaller-anaconda-5553 chroots=['fedora-eln-x86_64', 'fedora-rawhide-x86_64']): Unable to connect to https://copr.fedorainfracloud.org/api_3/.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@@ -94,6 +94,7 @@ def collect_unused_devices(storage):
and not d.partitioned
and (d.direct or d.isleaf)
and d not in used_devices
and d.format.type != "iso9660"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the purpose here to unmatch generally optical media?

Maybe using find_optical_media is the correct way?

@M4rtinK can you help with review please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that perhaps what we are seeing it actually a bug - if the media is used to start the installation, there should be code that puts it to the list of protected devices, which I would expect will prevent it from showing up at all. So maybe that is broken ?

BTW, it looks like iso9660 might be not just on optical media but also bootable installation flash drives, once you dd an installation image on them.

I guess there could be also the case of a user having two bootable installation flash drives connected, one used to boot to the installation and then another one just connected. Then the second one could show up as iso9660 volume & the question is how should Anaconda handle it ? I guess provide an option to delete the partition iso9660?

Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants