Handling for corrupt or otherwise unsupported disklabels #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StorageDevice now includes a list of its children, so use that. Also, account for the device itself being protected -- not just its children.
Do not show the partitions or other devices on unsupported disklabels. This allows users to clear and reinitialize them or just ignore them.
| @@ -489,3 +489,8 @@ def reset_to_snapshot(self, storage, dispose=False): | |||
| # a snapshot of early storage as we got it from scanning disks without doing any | |||
| # changes | |||
| on_disk_storage = StorageSnapshot() | |||
|
|
|||
| def filter_unsupported_disklabel_devices(devices): | |||
There was a problem hiding this comment.
This is a terrible name for a function, but I don't have a better one. Except for maybe get_suported_disklabel_devices()? It's at least a bit shorter.
|
Looks good to me. |
|
I had fixed that function name but then I accidentally pushed an older version of the patches without that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the anaconda piece to storaged-project/blivet#427. The first patch is a touch-up for a recent commit. The next two are little tweaks to use blivet better, and the last one is the main event.