Improved handling of corrupt or otherwise unsupported disklabels #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2016
|
jenkins, test this please |
dwlehman
force-pushed
the
unsupported-disklabels
branch
3 times, most recently
from
3e7bd50
to
b06db0c
Compare
Even if we won't have proper support for the disklabel we can at least have a complete view of the storage layout, which will make it possible to completely clear the disk if asked to.
dwlehman
force-pushed
the
unsupported-disklabels
branch
from
b06db0c
to
e17aff5
Compare
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a total reversal from the "unusable storage" dialog I added last year. The idea here is that blivet should not be constrained by what disklabels parted supports. If there are partitions in the system for it, we should be able to identify them and whatever it built on them. We should also be able to completely clear them so that users can get to a known-good state. Here are the main points of what this patch set does:
udev/blkidprovide expected dataThe corresponding anaconda piece will hide all devices built on an unsupported disklabel from the user while allowing them to clear the disk or just ignore it. Kickstart's
clearpartshould also work as expected now with unsupported disklabels.