Load the product configuration files #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
commented
Feb 10, 2021
| import glob | ||
|
|
||
| RELEASE_STRING_FILE = "/etc/os-release" | ||
| LICENSE_FILE_GLOB = "/usr/share/redhat-release*/EULA*" |
There was a problem hiding this comment.
I could find only /usr/share/redhat-release/EULA on the installed system.
There was a problem hiding this comment.
Yep, as far as I can tell this is the only file used these days, so should be correct. :)
4 tasks
poncovka
force-pushed
the
master-load_product_configurations
branch
2 times, most recently
from
20caaef
to
c802337
Compare
|
Tested with kickstart tests and a fake EULA. |
Load the product configuration files to have the right defaults. Use the product name from the os-release files of the system environment. Simplify the product-related code.
poncovka
force-pushed
the
master-load_product_configurations
branch
from
c802337
to
b1ed608
Compare
|
Rebased. |
M4rtinK
approved these changes
Feb 22, 2021
| import glob | ||
|
|
||
| RELEASE_STRING_FILE = "/etc/os-release" | ||
| LICENSE_FILE_GLOB = "/usr/share/redhat-release*/EULA*" |
There was a problem hiding this comment.
Yep, as far as I can tell this is the only file used these days, so should be correct. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load the product configuration files to have the right defaults. Use
the product name from the os-release files of the system environment.
Simplify the product-related code.