Fix memcached dashboard + Updated Telemeter allow-list #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
bwplotka
changed the title
bwplotka
changed the title
bwplotka
approved these changes
Sep 15, 2022
philipgough
added a commit
that referenced
this pull request
Sep 16, 2022
* Fix memcached dashboard + Updated Telemeter allow-list (#321) * Fix memcached overview dashboard Signed-off-by: Matej Gera <matejgera@gmail.com> * Sync whitelist Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Matej Gera <matejgera@gmail.com> * Rename thanos-rule-syncer metrics port (#322) Rename thanos-rule-syncer metrics port Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * Enable hashing algorithm for receive to be set via parameter Note, this is a breakinbg change which requires the use of Thanos >= v0.28.0 Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com> Co-authored-by: Jéssica Lins <jessicaalins@gmail.com>
philipgough
added a commit
that referenced
this pull request
Sep 30, 2022
* Fix memcached dashboard + Updated Telemeter allow-list (#321) * Fix memcached overview dashboard Signed-off-by: Matej Gera <matejgera@gmail.com> * Sync whitelist Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Matej Gera <matejgera@gmail.com> * Rename thanos-rule-syncer metrics port (#322) Rename thanos-rule-syncer metrics port Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * Add Rules and Alertmanager SLOs (#298) * Add Rules & alerting SLOs panels * Add Telemeter SLOs * Remove unnecessary comment * Use rate for SLO query about alerts being delivered to upstream targets * Update rules sync SLO query * Add alerts for Rules and Alerting SLOs (#300) * Add alerts for Rules and Alerting SLOs * Add container selector to APIRulesSyncAvailabilityErrorBudgetBurning alert * Fix telemeter namespace, update sync SLO query in alerts * Refactor instanceNamespace function Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * SLOs: Prune unsupported labels (#325) SLOs: Prune unsupported labels (#325) Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * [observatorium-logs] Increase the querier timeout from 3m to 6m (#330) * Fix SLO alerting for metrics (#328) * Fix SLO alerting for metrics Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Add back code labels to exclude 4xx Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Add comment about fork Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Add OSD to rules-obsctl-reloader (#329) Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Add Loki ruler and static rules for tenant OCM (#331) * Add runbooks for Rules & Alerting SLOs alerts (#327) Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * Fix loki ruler memory requests (#332) * Fix ocm panic logs-based alert (#333) * Remove recycle annotations for loki rules (#334) * Add staging test alerts for rhobs logs (#335) * Fix alertmanager discovery for logs ruler (#338) * Use alertmanager v1 api for Loki ruler (#339) * Update Telemeter rules (#340) Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Enable hashing algorithm for receive to be set via parameter Note, this is a breakinbg change which requires the use of Thanos >= v0.28.0 Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com> Co-authored-by: Jéssica Lins <jessicaalins@gmail.com> Co-authored-by: Periklis Tsirakidis <periklis@redhat.com> Co-authored-by: Saswata Mukherjee <saswataminsta@yahoo.com> Co-authored-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the memcached overview dashboard. The mixin we are using depend on using the
clusterlabel, however we do not useclusterlabel (resulting in empty dashboards). Rather, we usenamespacein our other dashboards and this PR replaces usage ofclusterbynamespacefor memcached as well.Includes also metric allow-list refresh, which seem to got out of sync.