MON-3355: build: build and publish test harness images in release workflow #341
Conversation
|
/lgtm |
|
@jan--f , since this modifies release.yaml, could you also please provide link to the CI run on your local fork where this is tested ? |
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
build-test-harness
branch
from
ce00557
to
33fbbf3
Compare
|
@sthaha good point, run is at https://github.com/jan--f/observability-operator/actions/runs/6034088227 |
|
|
||
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Would we really need all history for all branches and tags?
There was a problem hiding this comment.
probably not for this action no. I'll check them all and push a PR. There are others that look suspect too.
|
/lgtm |
| - name: Setup Go environment | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: ${{ inputs.go-version }} |
There was a problem hiding this comment.
On an unrelated note, setup-go now allows pointing to go.mod - https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file
There was a problem hiding this comment.
oh very nice, I'll prep a PR
|
/approve |
|
/skip |
|
Waiting on a tide config change: openshift/release#42910 |
|
/lgtm |
jan--f
changed the title
|
@jan--f: This pull request references MON-3355 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, sthaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…bs#341) Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
… (#350) Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Fixes #298