Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3355: build: build and publish test harness images in release workflow #341

Merged
merged 1 commit into from
Sep 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/osd-test-harness-publish/action.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: 'Publish OSD test harness image'
description: 'Publishes the OSD test harness image'
inputs:
quay_login:
description: "Quay login"
required: true
quay_token:
description: "Quay token"
required: true
go-version:
description: "go version"
required: true
runs:
using: composite
steps:
- name: Setup Go environment
uses: actions/setup-go@v3
with:
go-version: ${{ inputs.go-version }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On an unrelated note, setup-go now allows pointing to go.mod - https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh very nice, I'll prep a PR

check-latest: true
cache: true

- name: Install tools
uses: ./.github/tools-cache

- name: Registry Login
uses: docker/login-action@v2
with:
registry: quay.io
username: ${{ inputs.quay_login }}
password: ${{ inputs.quay_token }}

- uses: actions/checkout@v3
with:
fetch-depth: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we really need all history for all branches and tags?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not for this action no. I'll check them all and push a PR. There are others that look suspect too.


- name: Build and publish test harness image
shell: bash
run: |
make osd-e2e-test-push
10 changes: 10 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -185,3 +185,13 @@ jobs:
quay_login: ${{ secrets.QUAY_LOGIN }}
quay_token: ${{ secrets.QUAY_TOKEN }}
go-version: ${{ env.go-version }}

- name: Publish test harness
uses: ./.github/osd-test-harness-publish
env:
IMAGE_BASE: ${{ secrets.IMAGE_BASE }}
VERSION: ${{ steps.version.outputs.version }}
with:
quay_login: ${{ secrets.QUAY_LOGIN }}
quay_token: ${{ secrets.QUAY_TOKEN }}
go-version: ${{ env.go-version }}