Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rhpvorderman refactor shedtools #3

Merged
merged 8 commits into from
Aug 6, 2018
Merged

Rhpvorderman refactor shedtools #3

merged 8 commits into from
Aug 6, 2018

Commits on Aug 5, 2018

  1. Fix extensions typo

    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    7a6dd40 View commit details
    Browse the repository at this point in the history

  2. Fix test_json default argument 

    This is needed when running `shed_tools test` without an explicit
`--test_json` argument.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    b6ea9e1 View commit details
    Browse the repository at this point in the history

  3. Only list repositories that are installed 

    Otherwise uninstalled repos would be listed, leading to `Skipped` when
you actually want to install them.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    7bc28cf View commit details
    Browse the repository at this point in the history

  4. Listing data managers requires API access

    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    57ac315 View commit details
    Browse the repository at this point in the history

  5. Avoid message attr when passing exception msg 

    This has been deprecated in python 3.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    16ede2a View commit details
    Browse the repository at this point in the history

  6. Use named attributes of namedtuple 

    Avoids mixups during tuple unpacking (wasn't broken here, but briefly
suspected it).
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    a43bcdb View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    ed0ba61 View commit details
    Browse the repository at this point in the history

  8. Avoid testing all installed tools 

    if all tools are skipped or in error.
Skipped tools are still tested if `--test_exisiting` is passed.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    cd46a4f View commit details
    Browse the repository at this point in the history