Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all jboss_admin::resource::* types should pass their name as the name to the wrapped jboss_resource type #87

Closed
itewk opened this issue Jul 30, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@itewk
Copy link
Contributor

itewk commented Jul 30, 2015

Currently it is impossible to configure two JBoss EAP servers with the jboss_admin module because the cli_path is passed as the name to the jboss_resource type by all of the jboss_admin::resources::* types. Instead the name field of the jboss_admin::resources::* types should be passed to the wrapped jboss_resource so that conflicts can be avoided.

@itewk
Copy link
Contributor Author

itewk commented Aug 17, 2015

@simhpl

If you want to try to do this you need to look at lib/tasks/manifest.erb, lines 64-68. That is the template used to generate all of the jboss_resources.

You then need to manually update all of the resources in internal/custom_resource, because they are all over rides for the autogenerated types where needed.

You then need to run the "rake resource:generate" command to generate all the new resources.

Then test.

Some more details on the generation can be found in the README.md in the Generating Resources section. Also see the Developer Setup section.

@vsimhv
Copy link

vsimhv commented Aug 17, 2015

@itewk
Great, thanks. I will look into it.
Changing the provider will also be necessary, right? I mean the jboss_resource provider? or the jboss_resource type as well?

@itewk
Copy link
Contributor Author

itewk commented Aug 17, 2015

@simhpl

the jboss_resource type already has an "address" field. You should be able to update the template to pass the jboss_admin::resource::::cli_path to the jboss_resource::address field and then pass the jboss_admin::resource::::name as the jobss_resource::name to prevent the duplicate resources assuming the user passes unique names to jboss_admin::resource::*

@itewk itewk self-assigned this Jan 4, 2016
itewk added a commit that referenced this issue Mar 13, 2016
…as the name to the wrapped jboss_resource type
itewk added a commit that referenced this issue Mar 13, 2016
…as the name to the wrapped jboss_resource type
@itewk itewk added this to the v2.0.0 milestone Apr 4, 2016
@itewk
Copy link
Contributor Author

itewk commented Apr 4, 2016

merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants