Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi platform build for Docker image #159

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

politician
Copy link
Contributor

This adds support for Mac M1 (and other arm processors)

Signed-off-by: Romain Barissat <romain-noreply@barissat.com>
@politician politician changed the title Add multi platform build Add multi platform build for Docker image Jun 27, 2022
@rhysd
Copy link
Owner

rhysd commented Jun 27, 2022

@politician Thank you for adding this. How did you confirm this change worked? Since I don't have M1 Mac, I cannot verify the change.

@politician
Copy link
Contributor Author

@rhysd Sorry it wasn't working due to Shellcheck arm64 not being present in the Alpine repo (?). I have modified the Dockerfile and repushed.

Screenshot 2022-06-27 at 12 29 20

@rhysd
Copy link
Owner

rhysd commented Jun 27, 2022

@politician Thank you for checking that. From your screenshot, it fails with YAML parse error. In the case, shellcheck is not run. Could you confirm the copied shellcheck binary works fine in the built image? Since only /usr/local/bin/shellcheck is copied, it may not work if it depends on some dynamic link libraries at runtime.

@politician
Copy link
Contributor Author

@rhysd in the ShellCheck Dockerfile, they do the same copy operation

ShellCheck works:
Screenshot 2022-06-27 at 13 33 09

@rhysd
Copy link
Owner

rhysd commented Jun 27, 2022

in the ShellCheck Dockerfile, they do the same copy operation

Oh, ok, then it should work (with all dependencies being statically linked?). Thanks for the confirmation

@rhysd rhysd merged commit 4df24b5 into rhysd:main Jun 27, 2022
@rhysd
Copy link
Owner

rhysd commented Jun 27, 2022

@politician Thank you! Merged.

@rhysd
Copy link
Owner

rhysd commented Jun 28, 2022

actionlint v1.6.15 was released and now linux/arm64 container is available.

https://hub.docker.com/layers/rhysd/actionlint/1.6.15/images/sha256-f63ee59f1846abce86ca9de1d41a1fc22bc7148d14b788cb455a9594d83e73f7?context=repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants