Fix install script version override #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install script (suggested to be used in CI pipelines) supports version overrides. This is especially useful in environments where tools and dependencies need to be pinned to a certain version. It seems this has been accidentally changed by an automated CI process during the latest release; version overrides no longer work, and instead, only the most recent release (`v1.6.14`) can be used. This change fixes the accidental commit by using the provided program argument instead of the hardcoded value when an overridden version is provided to `actionlint`. Closes rhysd#161 Signed-off-by: Matei David <matei@buoyant.io>
|
Nice catch! This was caused by a bug of CI release workflow. |
rhysd
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install script (suggested to be used in CI pipelines) supports
version overrides. This is especially useful in environments where tools
and dependencies need to be pinned to a certain version. It seems this
has been accidentally changed by an automated CI process during the
latest release; version overrides no longer work, and instead, only the
most recent release (
v1.6.14) can be used.This change fixes the accidental commit by using the provided program
argument instead of the hardcoded value when an overridden version is
provided to
actionlint.Closes #161
Signed-off-by: Matei David matei@buoyant.io
Tests
Apologies if the contribution was very straightforward. I'm working on integrating
actionlintin our pipeline and would rather use the install script as opposed to just curling the latest binary from the release page. Let me know if anything needs to be changed :)