Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Lint actions #366

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: Lint actions #366

wants to merge 26 commits into from

Commits on Oct 9, 2023

  1. Duplicate linting infrastructure to lint actions, too 

    For the moment we kept the old scheme and rules.
    @msw-kialo
    msw-kialo committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    61fecfd View commit details
    Browse the repository at this point in the history

  2. Draft action metadata parsing

    @lg-kialo
    lg-kialo committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    dae9310 View commit details
    Browse the repository at this point in the history

  3. Reenable a basic visitor and rules for action linting

    @msw-kialo
    msw-kialo committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8992b49 View commit details
    Browse the repository at this point in the history

  4. Add action input parsing

    @lg-kialo
    lg-kialo committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6b3655c View commit details
    Browse the repository at this point in the history

  5. Start parsing actions

    @msw-kialo
    msw-kialo committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5328f81 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Resolve staticcheck linting errors

    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    bf2f39c View commit details
    Browse the repository at this point in the history

  2. Parse javascript and docker actions

    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    cde5d87 View commit details
    Browse the repository at this point in the history

  3. Mimic dummy workflow/job while visits actions 

    It allows existing rules to function as are (they potentially make
preparation and post actions in Workflow* Job* functions).
    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f0c006c View commit details
    Browse the repository at this point in the history

  4. Parse outputs

    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f4693ce View commit details
    Browse the repository at this point in the history

  5. Add support for action linting to playground

    @lg-kialo
    lg-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    88bbdc2 View commit details
    Browse the repository at this point in the history

  6. Try to ignore broken test data for dogfooding tests

    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    ba8491f View commit details
    Browse the repository at this point in the history

  7. Fix more linting errors

    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8fe56c1 View commit details
    Browse the repository at this point in the history

  8. CI: workaround shellcheck/actionlint limitation 

    ">" stricts newlines with single spaces, but apparently this isn't
picked by actionlint/shellcheck
    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9f2987a View commit details
    Browse the repository at this point in the history

  9. Fix playground TS linting errors

    @lg-kialo
    lg-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    af49077 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'rhysd:main' into lint-actions

    @lg-kialo
    lg-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    bb3a340 View commit details
    Browse the repository at this point in the history

  11. Add action specific methods to visit interface 

    Starting to port rule_id, rule_expression and rule_shellcheck to
correctly handle action visits.
    @msw-kialo
    msw-kialo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8c3038a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Parse action's branding info and validate it

    @msw-kialo
    msw-kialo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    6cc4130 View commit details
    Browse the repository at this point in the history

  2. Link to right docs in comment

    @lg-kialo
    lg-kialo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bb1e69d View commit details
    Browse the repository at this point in the history

  3. Address TODO renaming workflowKeyVal

    @lg-kialo
    lg-kialo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ef14959 View commit details
    Browse the repository at this point in the history

  4. Update comment

    @lg-kialo
    lg-kialo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1275407 View commit details
    Browse the repository at this point in the history

  5. Reverse ActionCommon / Action 

    Use interface for the Runs block and a normal struct for the Action itself
    @msw-kialo
    msw-kialo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b95f955 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Unify interfaces 

    Select syntax to check based on file name or top-level yaml keys.
    @msw-kialo
    msw-kialo committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    3bd8075 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Cleanups and improved naming

    @msw-kialo
    msw-kialo committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4bf6973 View commit details
    Browse the repository at this point in the history

  2. More fixes

    @msw-kialo
    msw-kialo committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ae2dc96 View commit details
    Browse the repository at this point in the history

  3. Restructure / fix tests

    @msw-kialo
    msw-kialo committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    847623f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Add more tests

    @msw-kialo
    msw-kialo committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4b05130 View commit details
    Browse the repository at this point in the history