Merge pull request #49 from bampakoa/win-options

Handle window options passed in an immutable manner
rhysd · Nov 3, 2019 · 7fa12ca · 7fa12ca
2 parents 3655b45 + 1224501
commit 7fa12ca
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/example/main.js b/example/main.js
@@ -18,6 +18,20 @@ app.once('ready', function() {
     });
     w.loadURL('file://' + join(__dirname, 'index.html'));
 
+    const options = {
+        icon_path: join(__dirname, 'icon.png'),
+        copyright: 'Copyright (c) 2015 rhysd',
+        package_json_dir: __dirname,
+        win_options: {
+            resizable: false,
+            minimizable: false,
+            maximizable: false,
+            movable: false,
+            parent: w,
+            modal: true,
+        }
+    }
+
     const menu = Menu.buildFromTemplate([
         {
             label: 'Example',
@@ -46,6 +60,11 @@ app.once('ready', function() {
                             show_close_button: "Close"
                         }),
                 },
+                {
+                    label: 'About This App (modal with options)',
+                    click: () =>
+                        openAboutWindow(options),
+                },
             ],
         },
     ]);

diff --git a/src/index.ts b/src/index.ts
@@ -96,7 +96,7 @@ function normalizeParam(info_or_img_path: AboutWindowInfo | string | undefined |
                 "First parameter of openAboutWindow() must have key 'icon_path'. Please see the document: https://github.com/rhysd/electron-about-window/blob/master/README.md",
             );
         }
-        return info;
+        return { ...info };
     }
 }