Skip to content

Commit

Permalink
try an optional
Browse files Browse the repository at this point in the history
  • Loading branch information
rhysmdnz committed May 17, 2023
1 parent aeab54a commit 1427815
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 37 deletions.
2 changes: 0 additions & 2 deletions provider/cmd/pulumi-resource-containerregistry/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
},
"required": [
"image_tarball",
"imageTarballHash",
"remoteTag"
],
"inputProperties": {
Expand All @@ -95,7 +94,6 @@
},
"requiredInputs": [
"image_tarball",
"imageTarballHash",
"remoteTag"
],
"stateInputs": {
Expand Down
3 changes: 3 additions & 0 deletions provider/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ func Provider() tfbridge.ProviderInfo {
HashField: "image_tarball_hash",
},
},
"image_tarball_hash": {
MarkAsOptional: tfbridge.True(),
},
},
},
},
Expand Down
6 changes: 3 additions & 3 deletions sdk/dotnet/Resource.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public partial class Resource : global::Pulumi.CustomResource
/// Hash of the image tarball.
/// </summary>
[Output("imageTarballHash")]
public Output<string> ImageTarballHash { get; private set; } = null!;
public Output<string?> ImageTarballHash { get; private set; } = null!;

/// <summary>
/// Image tarball thing.
Expand Down Expand Up @@ -80,8 +80,8 @@ public sealed class ResourceArgs : global::Pulumi.ResourceArgs
/// <summary>
/// Hash of the image tarball.
/// </summary>
[Input("imageTarballHash", required: true)]
public Input<string> ImageTarballHash { get; set; } = null!;
[Input("imageTarballHash")]
public Input<string>? ImageTarballHash { get; set; }

/// <summary>
/// Image tarball thing.
Expand Down
13 changes: 5 additions & 8 deletions sdk/go/containerregistry/resource.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions sdk/nodejs/resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class Resource extends pulumi.CustomResource {
/**
* Hash of the image tarball.
*/
public readonly imageTarballHash!: pulumi.Output<string>;
public readonly imageTarballHash!: pulumi.Output<string | undefined>;
/**
* Image tarball thing.
*/
Expand Down Expand Up @@ -63,9 +63,6 @@ export class Resource extends pulumi.CustomResource {
resourceInputs["remoteTag"] = state ? state.remoteTag : undefined;
} else {
const args = argsOrState as ResourceArgs | undefined;
if ((!args || args.imageTarballHash === undefined) && !opts.urn) {
throw new Error("Missing required property 'imageTarballHash'");
}
if ((!args || args.image_tarball === undefined) && !opts.urn) {
throw new Error("Missing required property 'image_tarball'");
}
Expand Down Expand Up @@ -106,7 +103,7 @@ export interface ResourceArgs {
/**
* Hash of the image tarball.
*/
imageTarballHash: pulumi.Input<string>;
imageTarballHash?: pulumi.Input<string>;
/**
* Image tarball thing.
*/
Expand Down
37 changes: 18 additions & 19 deletions sdk/python/pulumi_containerregistry/resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,19 @@
@pulumi.input_type
class ResourceArgs:
def __init__(__self__, *,
image_tarball_hash: pulumi.Input[str],
image_tarball: pulumi.Input[Union[pulumi.Asset, pulumi.Archive]],
remote_tag: pulumi.Input[str]):
remote_tag: pulumi.Input[str],
image_tarball_hash: Optional[pulumi.Input[str]] = None):
"""
The set of arguments for constructing a Resource resource.
:param pulumi.Input[str] image_tarball_hash: Hash of the image tarball.
:param pulumi.Input[Union[pulumi.Asset, pulumi.Archive]] image_tarball: Image tarball thing.
:param pulumi.Input[str] remote_tag: The tag to save the image to.
:param pulumi.Input[str] image_tarball_hash: Hash of the image tarball.
"""
pulumi.set(__self__, "image_tarball_hash", image_tarball_hash)
pulumi.set(__self__, "image_tarball", image_tarball)
pulumi.set(__self__, "remote_tag", remote_tag)

@property
@pulumi.getter(name="imageTarballHash")
def image_tarball_hash(self) -> pulumi.Input[str]:
"""
Hash of the image tarball.
"""
return pulumi.get(self, "image_tarball_hash")

@image_tarball_hash.setter
def image_tarball_hash(self, value: pulumi.Input[str]):
pulumi.set(self, "image_tarball_hash", value)
if image_tarball_hash is not None:
pulumi.set(__self__, "image_tarball_hash", image_tarball_hash)

@property
@pulumi.getter
Expand All @@ -63,6 +52,18 @@ def remote_tag(self) -> pulumi.Input[str]:
def remote_tag(self, value: pulumi.Input[str]):
pulumi.set(self, "remote_tag", value)

@property
@pulumi.getter(name="imageTarballHash")
def image_tarball_hash(self) -> Optional[pulumi.Input[str]]:
"""
Hash of the image tarball.
"""
return pulumi.get(self, "image_tarball_hash")

@image_tarball_hash.setter
def image_tarball_hash(self, value: Optional[pulumi.Input[str]]):
pulumi.set(self, "image_tarball_hash", value)


@pulumi.input_type
class _ResourceState:
Expand Down Expand Up @@ -172,8 +173,6 @@ def _internal_init(__self__,
raise TypeError('__props__ is only valid when passed in combination with a valid opts.id to get an existing resource')
__props__ = ResourceArgs.__new__(ResourceArgs)

if image_tarball_hash is None and not opts.urn:
raise TypeError("Missing required property 'image_tarball_hash'")
__props__.__dict__["image_tarball_hash"] = image_tarball_hash
if image_tarball is None and not opts.urn:
raise TypeError("Missing required property 'image_tarball'")
Expand Down Expand Up @@ -216,7 +215,7 @@ def get(resource_name: str,

@property
@pulumi.getter(name="imageTarballHash")
def image_tarball_hash(self) -> pulumi.Output[str]:
def image_tarball_hash(self) -> pulumi.Output[Optional[str]]:
"""
Hash of the image tarball.
"""
Expand Down

0 comments on commit 1427815

Please sign in to comment.