Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable BaseHeight & MaxHeight #34

Closed
vniehues opened this issue Jan 21, 2022 · 3 comments · Fixed by #35
Closed

Configurable BaseHeight & MaxHeight #34

vniehues opened this issue Jan 21, 2022 · 3 comments · Fixed by #35

Comments

@vniehues
Copy link

vniehues commented Jan 21, 2022

Hi there,

I plan to add configurable BaseHeight & MaxHeight to my HomeBridge Plugin.
It would be nice if I could pass these values to your idasen-controller.
The perfect way for me would be with argument flags like these:

Idasen-controller --move-to 850 --base-height 600 --max-height 1300

As it stands right now, when I try to send the desk down to lets say 580mm, your script would prevent that (because it's lower than the desk height).

What is your stance on this?

Edit: I just saw #29 and I think if we could add the max-height as well this could be the perfect solution.

@rhyst
Copy link
Owner

rhyst commented Jan 21, 2022

Hey, I just merged a PR that adds a configurable base height. I will add an option to configure the movement range as well.

@vniehues
Copy link
Author

Oh no.. we were at it at the same time so I commented on that merged PR. Sorry for that.
Thank your for looking into the movement range! I'm looking forward to integrating it into the plugin :)

@rhyst
Copy link
Owner

rhyst commented Jan 21, 2022

subraizada3 added this moments ago. I will make a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants