Make desk base height a config option #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabletops of my Idasens measure 61 cm @ lowest setting to 126 cm @ highest setting, which is 1cm lower than the nonconfigurable default base height used here (details on that below).
tldr:
This commit adds a
base_height
config option /base-height
argument. It also adds two more options/arguments,sit_height_offset
andstand_height_offset
. Those allow specifying an amount of mm above the base height, and then the absolute height to use is calculated at runtime. To maintain backwards compatibility, the sit/stand_height options are unchanged. The new*_height_offset
options are not required, but if specified they will override the existing*_height
options.Measurement data:
One Idasen was purchased two years ago and used on a wooden floor; I measured it at that time and noted down the values since I myself was reverse engineering the bluetooth protocol.
The current one was purchased a few months ago at a different location and measured with a different measuring tape, on carpet.
My measuring tapes only had/have inches. The actual measurements on my current desk were just a bit (less than 1/4") under 24" (60.96 cm) at the lowest setting, and almost exactly 49.5" (125.73 cm) at the top. For my old desk, I had 24" and 49.75" saved in my notepad. When measuring, I did make sure to keep the tape perpendicular to the ground and desk, so I have no reason to believe that these values are inaccurate for my desks.