Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make desk base height a config option #29

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

subraizada3
Copy link
Contributor

The tabletops of my Idasens measure 61 cm @ lowest setting to 126 cm @ highest setting, which is 1cm lower than the nonconfigurable default base height used here (details on that below).

tldr:

  • This repository uses as default: 62, 127 (+65cm range of motion)
  • I measured: 61, 126 (+65cm range of motion)
  • Ikea specifies: 63, 127 cm (+64cm range of motion)

This commit adds a base_height config option / base-height argument. It also adds two more options/arguments, sit_height_offset and stand_height_offset. Those allow specifying an amount of mm above the base height, and then the absolute height to use is calculated at runtime. To maintain backwards compatibility, the sit/stand_height options are unchanged. The new *_height_offset options are not required, but if specified they will override the existing *_height options.


Measurement data:

One Idasen was purchased two years ago and used on a wooden floor; I measured it at that time and noted down the values since I myself was reverse engineering the bluetooth protocol.

The current one was purchased a few months ago at a different location and measured with a different measuring tape, on carpet.

My measuring tapes only had/have inches. The actual measurements on my current desk were just a bit (less than 1/4") under 24" (60.96 cm) at the lowest setting, and almost exactly 49.5" (125.73 cm) at the top. For my old desk, I had 24" and 49.75" saved in my notepad. When measuring, I did make sure to keep the tape perpendicular to the ground and desk, so I have no reason to believe that these values are inaccurate for my desks.

@rhyst
Copy link
Owner

rhyst commented Jan 17, 2022

Hey, thanks for the contribution! I'd be very happy to include this but can you add the options to the README as well?

@subraizada3
Copy link
Contributor Author

Done.

@rhyst rhyst merged commit ebdf836 into rhyst:master Jan 21, 2022
@vniehues
Copy link

@subraizada3 would you be able to add a max-height flag as well? That could solve #34 really fast :)

@subraizada3
Copy link
Contributor Author

@subraizada3 would you be able to add a max-height flag as well? That could solve #34 really fast :)

Added PR #35

rhyst added a commit that referenced this pull request Feb 6, 2023
Make desk base height a config option
rhyst added a commit that referenced this pull request Feb 6, 2023
Make desk base height a config option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants