Wrong bucket types/names/keys PB encoding

[llelf]

riak-haskell-client has been doing BucketType/Bucket/Key encoding
wrong basically from the beginning. I don't know the reason @bos did
it the way it is.

I'm going to fix it, but I have two questiongs to the maintainers:

1. It won't affect ordinary ascii-only names in any way, so it'd
   prefer it to just be a backward-incompatible change. What do you
   think? Besides, there were no complaints all this time. ;)
2. Those names are actually Text. What do you think about this
   change?
   It shouldn't affect performance since you need to traverse those
   strings to look for special characters anyway (and we do it now).

[tmcgilchrist]

Thanks @llelf, could you go into more detail about how the escaping is wrong? Assuming you mean the code in Escape.hs

I'm assuming from comment 1 it's working for ASCII but not for unicode (perhaps UTF-8 specifically)

1. I'm not sure I follow this.

[llelf]

@tmcgilchrist, it over-quotes them. It does url-escaping of, while it should only quote a '/'. Assuming the name is a proper utf-8, hence the question about Text.

1. If you put data into bucket "ξ" (or any non-ascii), you won't be able to read it from "ξ" with the new version of riak-haskell-client. We could think about some backward compatibility scheme here, but it'd say it is unjustified and just declare it to be backward-incompatible. All ascii-only names will continue to work anyway.

[llelf]

ping!

[mitchellwrosen]

Ping number 2 =)

[tmcgilchrist]

This is slowly bubbling to the top of my stack. I'd like to get some of the
other or changes in first before tackling this.

On Wednesday, 5 October 2016, Mitchell Rosen notifications@github.com
wrote:

Ping number 2 =)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKbuaUMaITSW8mKebCHUtIfU849SUvWks5qwmS3gaJpZM4Ij-nS
.