Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar event's Equals and GetHashCode methods don't match #271

Closed
rianjs opened this issue Apr 27, 2017 · 2 comments
Closed

Calendar event's Equals and GetHashCode methods don't match #271

rianjs opened this issue Apr 27, 2017 · 2 comments
Labels
Beginner bug

Comments

@rianjs
Copy link
Owner

rianjs commented Apr 27, 2017

Equals() considers attachments. GetHashCode does not.
@rianjs
Copy link
Owner Author

rianjs commented Apr 28, 2017

The RFC allows attachments on all calendar components. I.e.:

  • Event
  • To-Do
  • Journal
  • Free/Busy
  • Time Zone
  • Alarm

So I'll drive through and make sure GetHashCode() and Equals() consider the appropriate properties, since I noticed that Alarm does not.

rianjs pushed a commit that referenced this issue Apr 28, 2017
Journals, Todos, Events have symmetrical GetHashCode and Equals methods
1a7b996 
#271
rianjs pushed a commit that referenced this issue Apr 28, 2017
Nuspec and release notes updates #271
66a493c
@rianjs
Copy link
Owner Author

rianjs commented Apr 28, 2017

In nuget packages:

  • 2.2.35
  • 3.0.4-net-core-alpha

@rianjs rianjs closed this as completed Apr 28, 2017
@rianjs rianjs mentioned this issue Apr 28, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rianjs