Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make custom palette available for diverging color scheme #78

Closed
rysebaert opened this issue Jul 6, 2022 · 4 comments · Fixed by #88
Closed

make custom palette available for diverging color scheme #78

rysebaert opened this issue Jul 6, 2022 · 4 comments · Fixed by #88
Milestone

Comments

@rysebaert
Copy link
Member

Animation

@mthh mthh added this to the 0.8.15 milestone Aug 22, 2022
@mthh
Copy link
Member

mthh commented Aug 22, 2022

Thanks for the report !
I'm not totally sure to solve this issue as proposed (i.e. add the "custom palette" option also for "diverging scheme").

In fact, it is already possible to create a custom diverging scheme with the proposed option (even if it is in the "sequential scheme"). The problem is rather that the "custom palette" option is not in the right place in my opinion.

I think we should not have "sequential scheme" (including custom palette possibility) OR "diverging scheme" (including custom palette possibility) but rather "sequential scheme" OR "diverging scheme" OR "custom palette" (3 radios buttons instead of two - and we remove the small "Custom palette ?" text that is in italic).

What do you think ?

@mthh mthh mentioned this issue Aug 24, 2022
15 tasks
@mthh
Copy link
Member

mthh commented Aug 25, 2022

I postpone the correction of this issue to version 0.9.0.
I think I should take the opportunity of this enhancement to improve the appearance of some of the elements in this panel.

@mthh mthh modified the milestones: 0.8.15, 0.9.0 Aug 25, 2022
@rysebaert
Copy link
Member Author

Totally agree with the solution you propose !

@mthh
Copy link
Member

mthh commented Aug 25, 2022

Awesome !
I will release 0.8.15 tomorrow (if nothing bad happens during some last tests!) then I will start working on this discretisation panel.

@mthh mthh modified the milestones: 0.9.0, 0.10.0 Aug 31, 2022
@mthh mthh closed this as completed in #88 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants