Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/typo symbol filtering #106

Merged
merged 22 commits into from
Mar 20, 2023
Merged

Features/typo symbol filtering #106

merged 22 commits into from
Mar 20, 2023

Commits on Mar 16, 2023

  1. added js for being able to check which picto we want to show or hide

    Robin committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    b2bbeea View commit details
    Browse the repository at this point in the history

  2. added css styling to match global magrit look. added js commentary

    Robin committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    70f1fcd View commit details
    Browse the repository at this point in the history

  3. Added translation for checbox description

    Robin committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    c4352ba View commit details
    Browse the repository at this point in the history

  4. feature/typo_symbol_filtering ready 

    Co-authored-by: ArmelVidali <vidali.armel@gmail.com>
    @ArmelVidali
    Robin and ArmelVidali committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    857664a View commit details
    Browse the repository at this point in the history

  5. Removed unecessary subgit repo for PR 

    Co-authored-by: ArmelVidali <vidali.armel@gmail.com>
    @ArmelVidali
    Robin and ArmelVidali committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5c125af View commit details
    Browse the repository at this point in the history

  6. Fixed _tr("translation") typo mistake in js 

    Co-authored-by: ArmelVidali <vidali.armel@gmail.com>
    @ArmelVidali
    Robin and ArmelVidali committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5b1d439 View commit details
    Browse the repository at this point in the history

  7. Added the list of hidden_pictograms to render_TypoSymbols function 

    Co-authored-by: ArmelVidali <vidali.armel@gmail.com>
    @ArmelVidali
    Robin and ArmelVidali committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    aebe2e2 View commit details
    Browse the repository at this point in the history

  8. correction for render_TypoSymols - doesn't add filtered images to the… 

    … DOM
    armel committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    50b1c38 View commit details
    Browse the repository at this point in the history

  9. fixed typo mistakes and removed unnecessary class

    armel committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    08bd50f View commit details
    Browse the repository at this point in the history

  10. added smoomacypy to gitignreo so it doesnt push its src/

    Robin committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    7b16c8c View commit details
    Browse the repository at this point in the history

  11. change symbol rendering so its using more of basic magrit functioning

    Robin committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5ce9098 View commit details
    Browse the repository at this point in the history

  12. Improved the way we display selected typo symbols on the map 

    so it's using generic magrit legend functions
Added filtered symbols to project save so we can retreive the information on project load
On project load, added logic to display only previously filtered symbols
    Robin committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    69fd15c View commit details
    Browse the repository at this point in the history

  13. Removed unecessary comments for PR 

    Co-authored-by: ArmelVidali <vidali.armel@gmail.com>
    @ArmelVidali
    Robin and ArmelVidali committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    b06757d View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Changed the symbols_map of rendering_params into symbols_to_display 

    We do this so it does not override the first symbols_map which contains all available fields for the category
Then changed the naming symbol_map to symbols_to_display in data_manager for legend projection, saving and loading project and reprojecting layers
    Robin committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    2ad70f8 View commit details
    Browse the repository at this point in the history

  2. Removed comments that were used for debugging

    Robin committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    537dc78 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Fix bug when category value is a number

    @mthh
    mthh committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5da6ee5 View commit details
    Browse the repository at this point in the history

  2. Fix bug when reloading when category value is a number

    @mthh
    mthh committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    427893a View commit details
    Browse the repository at this point in the history

  3. Fix some formatting / trailing whitespace / etc. issues

    @mthh
    mthh committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    81fd48d View commit details
    Browse the repository at this point in the history

  4. Fix where filtering of unselected typo symbols happens to avoid empty… 

    … image elements
    @mthh
    mthh committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    88d1be4 View commit details
    Browse the repository at this point in the history

  5. Update changelogs

    @mthh
    mthh committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    f1bf804 View commit details
    Browse the repository at this point in the history

  6. Remove outdated comment

    @mthh
    mthh committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    05cd43e View commit details
    Browse the repository at this point in the history

  7. Remove new duplicate entry in gitignore

    @mthh
    mthh committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    91c275b View commit details
    Browse the repository at this point in the history