Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker and Go modules #70

Closed
checkaayush opened this issue Apr 1, 2019 · 2 comments
Closed

Docker and Go modules #70

checkaayush opened this issue Apr 1, 2019 · 2 comments

Comments

@checkaayush
Copy link

checkaayush commented Apr 1, 2019 •
edited
Loading

  • I feel adding docker and docker-compose setup will make local development way easier and could replace the replace-all package steps while getting started.
  • Also, how about using Go modules?

A makefile target can also be used instead of manual package name change. See this.

Would be happy to submit PRs if above sound useful.

P.S.: Nice work on v2 👍
@ribice
Copy link
Owner

ribice commented May 31, 2019

Both would be good to do!

wingkwong added a commit to wingkwong/gorsk that referenced this issue Nov 17, 2019
@wingkwong
ribice#70 Add Makefile
44c2530
wingkwong added a commit to wingkwong/gorsk that referenced this issue Nov 17, 2019
@wingkwong
ribice#70 Update README.md to include make relocate
eaa3a60
@wingkwong wingkwong mentioned this issue Nov 17, 2019
Merged
wingkwong added a commit to wingkwong/gorsk that referenced this issue Nov 17, 2019
@wingkwong
ribice#70 Add Taskfile
019c9dd
@ribice
Copy link
Owner

ribice commented Mar 24, 2020

Added GoModules via #84

@ribice ribice closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@checkaayush @ribice