-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use params.sections (if present) for sections #23
Conversation
Fixes #22 |
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
This will add a second nav bar under site name, with entries from params.sections. Example: [params.sections] "/" = "~/" "/posts" = "Posts" "/projects" = "Projects" Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
See: gohugoio/hugo#3262 Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
My site still uses Hemingway theme (forked one), and I apply changes there after pushing them Kiss. I'll migrate my blog in few following days and test your changes. |
@ribice cool, thanks. My site is live, running my fork with these changes: https://www.oleherman.com/ |
@olehermanse Can you update the readme and exampleSite for these changes? Thanks! |
Add a basic nav bar with section types
I see @mateimicu has updated this and also README, thanks! @ribice You should consider using merge instead of squash in GitHub UI (unless commit history is messy). This PR had 3 commits, one which was written by @mateimicu , and 1 change to css link (which isn't really related to params.sections). You "destroy" this history by squashing it into 1 commit. (It is also nicer in a lot of other subtle ways, like preserving hashes, gpg signatures and makes |
@olehermanse Haven't thought of that. Generally I squash my own commits since I make plenty of them while working on a single feature. Will make merge commits from now on. Sorry. |
@ribice no worries. Squashing makes sense sometimes, but not always :) |
This will add a second nav bar under site name,
with entries from params.sections.
If you don't add these params, generated markup will be exactly like before
Example: