Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use params.sections (if present) for sections #23

Merged
merged 3 commits into from
Apr 17, 2018

Conversation

olehermanse
Copy link
Contributor

This will add a second nav bar under site name,
with entries from params.sections.

If you don't add these params, generated markup will be exactly like before

Example:

[params.sections]
"/" = "~/"
"/posts" = "Posts"
"/projects" = "Projects"

screenshot

@olehermanse
Copy link
Contributor Author

Fixes #22

mateimicu and others added 2 commits April 10, 2018 03:42
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
This will add a second nav bar under site name,
with entries from params.sections.

Example:

	[params.sections]
	"/" = "~/"
	"/posts" = "Posts"
	"/projects" = "Projects"

Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
See: gohugoio/hugo#3262

Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
@ribice
Copy link
Owner

ribice commented Apr 16, 2018

My site still uses Hemingway theme (forked one), and I apply changes there after pushing them Kiss. I'll migrate my blog in few following days and test your changes.

@olehermanse
Copy link
Contributor Author

@ribice cool, thanks. My site is live, running my fork with these changes: https://www.oleherman.com/

@ribice ribice merged commit 93e6aa4 into ribice:master Apr 17, 2018
@ribice
Copy link
Owner

ribice commented Apr 17, 2018

@olehermanse Can you update the readme and exampleSite for these changes? Thanks!

russparsloe pushed a commit to russparsloe/kiss that referenced this pull request Apr 28, 2018
Add a basic nav bar with section types
@olehermanse
Copy link
Contributor Author

I see @mateimicu has updated this and also README, thanks!

@ribice You should consider using merge instead of squash in GitHub UI (unless commit history is messy). This PR had 3 commits, one which was written by @mateimicu , and 1 change to css link (which isn't really related to params.sections). You "destroy" this history by squashing it into 1 commit. (It is also nicer in a lot of other subtle ways, like preserving hashes, gpg signatures and makes git rebase work better).

@ribice
Copy link
Owner

ribice commented May 20, 2018

@olehermanse Haven't thought of that. Generally I squash my own commits since I make plenty of them while working on a single feature. Will make merge commits from now on. Sorry.

@olehermanse
Copy link
Contributor Author

@ribice no worries. Squashing makes sense sometimes, but not always :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants