Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Ruby 3.0 #79

Closed
skalee opened this issue Jan 28, 2020 · 4 comments
Closed

Update for Ruby 3.0 #79

skalee opened this issue Jan 28, 2020 · 4 comments

Comments

@skalee
Copy link
Contributor

skalee commented Jan 28, 2020

  • Builds on master against 2.7 output lots of deprecation warnings.
  • Builds on master against Ruby HEAD do fail.
@skalee
Copy link
Contributor Author

skalee commented Jan 29, 2020

Looks like all the warnings come from two sources:

– Rails 6, which is independent from us.
– Tests, in which given custom masker expects keyword arguments whereas a regular hash is passed.

Regarding the latter, I need to make a careful decision whether custom maskers should accept hashes or keyword arguments. For now, I am leaning towards the second option.

@skalee skalee changed the title Update for Ruby 3.0 Update for Ruby 2.8 Jan 30, 2020
@skalee skalee changed the title Update for Ruby 2.8 Update for Ruby 3.0 Jan 30, 2020
@skalee
Copy link
Contributor Author

skalee commented Jan 30, 2020

For the record, according to current plans Ruby 3.0 is due in about eleven months, though they may release Ruby 2.8 instead — https://bugs.ruby-lang.org/projects/ruby-master/roadmap.

@skalee
Copy link
Contributor Author

skalee commented Jan 30, 2020

Looks like build errors come from the latest Rails release, which is not compatible with Ruby HEAD.

@skalee
Copy link
Contributor Author

skalee commented Sep 19, 2020

I'm closing this one as it's not very relevant yet. We can reopen it when Ruby 3 reaches beta stage.

Regarding other issues which were mentioned in the discussion:

@skalee skalee closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant