Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize warnings output with Warning gem #85

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Organize warnings output with Warning gem #85

merged 1 commit into from
Jan 30, 2020

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Jan 30, 2020

Ignore warnings coming from other gems, and deduplicate remaining ones. Having said that, Warnings gem must be added to Gemfile or somehow manually loaded in order to work.

I am not adding it to gemspec, because it requires Ruby 2.4, and I don't want to drop older Rubies for a rather silly reason.

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #85 into master will decrease coverage by 0.26%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   62.67%   62.41%   -0.27%     
==========================================
  Files          26       26              
  Lines         560      564       +4     
==========================================
+ Hits          351      352       +1     
- Misses        209      212       +3
Impacted Files Coverage Δ
spec/spec_helper.rb 52.94% <25%> (-8.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff8b21...069a0b1. Read the comment docs.

Ignore warnings coming from other gems, and deduplicate remaining ones.
Having said that, Warnings gem must be added to Gemfile or somehow
manually loaded in order to work.
@skalee skalee merged commit 4e44d28 into master Jan 30, 2020
@skalee skalee deleted the warnings branch January 30, 2020 19:00
@skalee skalee mentioned this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant