Use keyword arguments in all maskers consistently #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit conversions between hashes and keyword arguments is deprecated in modern Rubies, and will not work in Ruby 3.0. Maskers should be parametrized with keyword arguments, not Ruby 1.9-style options hashes, and this very commit fixes that. This commit resolves all Ruby 2.7 warnings, except for those coming from external libraries (e.g. Rails). See: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
===========================================
+ Coverage 62.34% 99.41% +37.06%
===========================================
Files 26 24 -2
Lines 563 340 -223
===========================================
- Hits 351 338 -13
+ Misses 212 2 -210
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit conversions between hashes and keyword arguments is deprecated in modern Rubies, and will not work in Ruby 3.0. Maskers should be parametrized with keyword arguments, not Ruby 1.9-style options hashes, and this very change fixes that.
This change resolves all Ruby 2.7 warnings (see #79), except for those coming from external libraries (e.g. Rails).
See: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/