Allow webhook to be configured globally #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,33 +2,52 @@ | |||
| set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x | |||
| source "$(dirname $0)/../common/functions" | |||
|
|
|||
| is_webhook() { | |||
| echo "$1" | grep '^http' | |||
There was a problem hiding this comment.
Would this not also match if an app name begins with http, for example httpserver?
There was a problem hiding this comment.
Yep you’re right! I’m making a small adjustment :)
|
Just one small comment. The rest looks very good! |
The "app" part of the existing commands is now optional and allows the webhook to be enabled globally (for all apps). When a global webhook is enabled and a specific one for an app is also enabled, the notification will be send to the specific one.
|
Done! :) |
|
@matto1990 any update on this? :) |
|
Looks good. The only minor issue I've found is that if you have a global webhook set and query the webhook for a single app it should likely return the global URL as that will actually be used. I'm happy to merge this in as it is though! Thanks for the great work and really sorry about the long delay! |
matt-oakes
pushed a commit
that referenced
this pull request
Apr 18, 2015
Allow webhook to be configured globally
|
Ok great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "app" part of the existing commands is now optional and allows the
webhook to be enabled globally (for all apps).
When a global webhook is enabled and a specific one for an app is also
enabled, the notification will be send to the specific one.