The hasTag was always returning false, which probably is a bug. Fixed…

… it and added a test to catch it.

src/SemanticScuttle/Service/Bookmark2Tag.php

@@ -627,13 +627,14 @@ function hasTag($bookmarkid, $tag) {
             message_die(GENERAL_ERROR, 'Could not find tag', '', __LINE__, __FILE__, $query, $this->db);
             return false;
         }
-
+
+        $output = false;
         if ($row =& $this->db->sql_fetchrow($dbresult)) {
             if ($row['tCount'] > 0) {
                 $output = true;
             }
         }
-        $output = false;
+
         $this->db->sql_freeresult($dbresult);
         return $output;
     }

tests/Bookmark2TagTest.php

@@ -667,5 +667,15 @@ public function testGetContactTagsBeginsWith()
         $this->assertContains(array('tag' => 'usertag1', 'bCount' => '1'), $arTags);
         $this->assertContains(array('tag' => 'usable', 'bCount' => '2'), $arTags);
     }
+
+    public function testHasTag() {
+        $bid = $this->addBookmark(null, null, 0, array('foo'));
+
+        $this->assertTrue($this->b2ts->hasTag($bid, 'foo'));
+        //this test is because we are using the utf8_general_ci encoding,
+        //which removes all accents
+        $this->assertTrue($this->b2ts->hasTag($bid, 'fóo'));
+
+    }
 }
 ?>