Rename "connection" promise to "opened" #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For alignment with Direct Sockets, rename the "connection" promise to "opened".
|
@domenic This look okay? |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 19, 2023
See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 21, 2023
See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 27, 2023
See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175907}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 27, 2023
See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175907}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 27, 2023
See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175907}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 2, 2023
…"opened", a=testonly Automatic update from web-platform-tests WebSocketStream: Rename "connection" to "opened" See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175907} -- wpt-commits: 3bdd1a1562d55842cb4f13dda3432df2f779ffa6 wpt-pr: 41040
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Aug 4, 2023
…"opened", a=testonly Automatic update from web-platform-tests WebSocketStream: Rename "connection" to "opened" See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175907} -- wpt-commits: 3bdd1a1562d55842cb4f13dda3432df2f779ffa6 wpt-pr: 41040
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175907}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For alignment with Direct Sockets, rename the "connection" promise to "opened".
Fixes #14.