WebSocketStream: Rename "connection" to "opened" #41040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 14, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4685590
branch
4 times, most recently
from
0f571b5
to
962ab71
Compare
See ricea/websocketstream-explainer#16 Also add some unit tests for use of AbortSignal. This was already tested by wpts, but I need to keep the coverage bot happy. Change-Id: I559553796a8d1358506d26800108105be58a0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175907}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4685590
branch
from
962ab71
to
2c8ef26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ricea/websocketstream-explainer#16
Also add some unit tests for use of AbortSignal. This was already
tested by wpts, but I need to keep the coverage bot happy.
Change-Id: I559553796a8d1358506d26800108105be58a0e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685590
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175907}