This repository has been archived by the owner on Jul 7, 2022. It is now read-only.
Fixed compatibility with websocket-client callbacks [see #173] #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter#173] The websocket-client callbacks, as of 0.58 (richard-better@01c791c), require the websocket application object as first argument. Since things are the other way around for websocket-client >= 0.53.0, and yet the other way around on previous versions, this commit is supposed to stop the madness around websocket-client callbacks with a dynamic list of arguments. - Fixed docstring for the Listener object. - Fixed list of arguments inherited by run_forever.
rbrcsk
approved these changes
Apr 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The websocket-client callbacks, as of 0.58 (01c791c),
require the websocket application object as first argument. Since things are the
other way around for websocket-client >= 0.53.0, and yet the other way around on
previous versions, this commit is supposed to stop the madness around
websocket-client callbacks with a dynamic list of arguments.
Fixed docstring for the Listener object.
Fixed list of arguments inherited by run_forever.