Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for VKB Kosmosima SCG Right #41

Merged
merged 10 commits into from May 25, 2020

Conversation

ajhewett
Copy link
Contributor

@ajhewett ajhewett commented Mar 4, 2020

This pull request adds:

  • support for the VKB Kosmosima SCG Right
  • my current ED bindings for VKB Kosmosima SCG Right together with a Thrustmaster T1600 Throttle
  • a Dockerfile with the necessary apache2 config

I have been running EDRefCard in a Docker container on my home NAS while tinkering with the bindings. Works great!

The reference sheet image was taken from https://vkbcontrollers.com/wp-content/uploads/2019/01/SCG_Right.pdf

NOTE: I don't have afdesign so created a .svg file with Inkscape.

@coveralls
Copy link

coveralls commented Mar 4, 2020

Coverage Status

Coverage remained the same at 42.443% when pulling f0c061b on ajhewett:dev into 1e15cb3 on richardbuckle:dev.

@ajhewett
Copy link
Contributor Author

@richardbuckle Any feedback?
I'm happy to change or remove anything. For example, the Dockerfile and apache2 config was mostly for my convenience.

@richardbuckle richardbuckle self-assigned this Mar 25, 2020
@richardbuckle
Copy link
Owner

Thanks for the reminder. With all the real life stuff going on, I've been a bit distracted from the hobby projects. Looks good at first glance and I shall make time to check the details.

I'm not very au fait with Docker but the format looks reasonable enough, so provided it meshes with my own Apache config I'm not opposed to it. The purist view would be to separate the tasks into two PRs but I'd say that's overkill here.

@richardbuckle
Copy link
Owner

Oh and BTW SVG files are fine. Any portable vector format is fine. I'm not wedded to afdesign, it just happens to be what jgm used back in the day.

Some other questions:

  1. Would you be willing to extend README.md with instructions for applying your Dockerfile (even if it feels obvious to you)?
  2. I see that the grip has a left-handed variant. Without blocking this particular PR, is it something you could easily do another PR for using VKB's PDF for that?

@richardbuckle
Copy link
Owner

Where are my manners? THANK YOU for taking the trouble to do this: I know first hand what painstaking work it is.

@richardbuckle richardbuckle self-requested a review March 25, 2020 23:46
@ajhewett
Copy link
Contributor Author

@richardbuckle thanks for the feedback.

  1. I will update the PR with some docker instructions in the README.md
  2. I can do the left-handed grip sometime. I want to purchase one when they come back in stock so that would be a good time for a new PR.

@ajhewett
Copy link
Contributor Author

ajhewett commented May 18, 2020

@richardbuckle I have added some Docker instructions, support for the left-hand grip and a working bindings file for my dual VKB setup.

CMDR ajh0

@richardbuckle richardbuckle merged commit 144fc35 into richardbuckle:dev May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants