Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed in PR #88 - Key.is_private (which is always True) is used in some places instead of Key.is_private() (which is sometimes False) #83

Closed
posita opened this issue Feb 22, 2015 · 0 comments
Closed

Fixed in PR #88 - Key.is_private (which is always True) is used in some places instead of Key.is_private() (which is sometimes False) #83

posita opened this issue Feb 22, 2015 · 0 comments

Comments

@posita
Copy link
Contributor

posita commented Feb 22, 2015

See, e.g.:

pycoin/pycoin/key/Key.py

Line 223 in 5a3f309

if self.is_private:

pycoin/pycoin/scripts/genwallet.py

Line 87 in 5a3f309

if wallet.is_private:

@posita posita changed the title Key.is_private is used in some places instead of Key.is_private() Key.is_private (which is always True) is used in some places instead of Key.is_private() (which is sometimes False) Feb 25, 2015
@posita posita mentioned this issue Feb 27, 2015
Closed
@posita posita changed the title Key.is_private (which is always True) is used in some places instead of Key.is_private() (which is sometimes False) Fixed in PR #88 - Key.is_private (which is always True) is used in some places instead of Key.is_private() (which is sometimes False) Mar 6, 2015
@posita posita mentioned this issue Mar 23, 2015
Merged
richardkiss added a commit that referenced this issue Mar 24, 2015
@richardkiss
Merge pull request #88 from posita/key-is-private-83
85c91fe 
READY FOR REVIEW - Fix #83. Key.is_private -> Key.is_private() where appropriate.
ghtdak pushed a commit to ghtdak/pycoin that referenced this issue Jul 16, 2016
@posita
Fix richardkiss#83. Key.is_private -> Key.is_private() where appropri…
e451618 
…ate.

[gitreformat yapf-ify (github/ghtdak) on Fri Jul 15 12:51:43 2016]
[from commit: 8044714]
ghtdak pushed a commit to ghtdak/pycoin that referenced this issue Jul 16, 2016
@richardkiss
Merge pull request richardkiss#88 from posita/key-is-private-83
218ac5a 
READY FOR REVIEW - Fix richardkiss#83. Key.is_private -> Key.is_private() where appropriate.
[gitreformat yapf-ify (github/ghtdak) on Fri Jul 15 12:51:46 2016]
[from commit: 85c91fe]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@posita