READY: Chain.com PROVIDER added + minor bug fix

[shayanb]

fixing #85

[posita]

👍 Thanks @shayanb!

EDIT: @mbogosian is now @posita.

[shayanb]

@mbogosian I can't find where it is included, anyhow it wasn't intended to be included, that is just a test file I'm using for playing around the library.

[posita]

@shayanb, sorry to beat a dead horse 🐴. This might expose my complete ignorance of how Git or GitHub work, but I was referring to commit 6da5b8a (fix BIP32 for testnet) referenced after my #86 (comment). It looks like that includes the modifications to .gitignore that I mentioned. If this is not the case, my apologies. I have precious little experience with cross-repository pull requests. 😊

Edit: I also see the changes to .gitignore under the files for this PR. The way I understand cross-repository pull requests to work is that all changes committed to the merge-from branch after the PR is created will show up in the PR. So if you create a PR from the master branch of your fork, any subsequent commits you make to your own master branch will also show up in the PR until that PR is closed. I was recently exposed to this behavior when I committed my fix to #83 to my own master branch (see #84), but then wanted to submit another PR for #89. In the end, I created two branches from the master branch of my fork to deal with each separately without polluting each other. Then I created PRs from those branches (see #88 and #90, respectively). My apologies if this is remedial. It's relatively new to me, since I don't do many of these.

[richardkiss]

This pull request has a lot going on in it. Some of the fixes have already been applied. @shayanb I'm going to close this request... if there are any changes that you think you need that aren't yet merged, perhaps you can do them one branch and change at a time so the discussion can be more focussed.

[shayanb]

@richardkiss sure, Thanks.
I will send another PR for chain.com provider. not sure the rest of the changes would be applicable anymore.