Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed in PR #99 - Call to script_obj_from_address from standard_tx_out_script doesn't use netcodes argument #85

Closed
posita opened this issue Feb 23, 2015 · 1 comment

Comments

@posita
Copy link
Contributor

posita commented Feb 23, 2015

See here. I'm pretty sure it should be this instead:

def standard_tx_out_script(address, netcodes=DEFAULT_NETCODES):
    script_obj = script_obj_from_address(address, netcodes=netcodes)
    if script_obj is None:
        raise ValueError("can't parse address %s" % address)
    return script_obj.script()

I'm on the road, but I'll submit a patch when I can (unless someone else gets to it first).

@shayanb
Copy link
Contributor

shayanb commented Feb 23, 2015

#86

@posita posita changed the title Call to script_obj_from_address from standard_tx_out_script doesn't use netcodes argument Fixed in PR #99 - Call to script_obj_from_address from standard_tx_out_script doesn't use netcodes argument Mar 6, 2015
richardkiss added a commit that referenced this issue Mar 6, 2015
Fix #85. Pass netcodes parameter through to subcall.
ghtdak pushed a commit to ghtdak/pycoin that referenced this issue Jul 16, 2016
[gitreformat yapf-ify (github/ghtdak) on Fri Jul 15 12:51:43 2016]
[from commit: f1460ba]
ghtdak pushed a commit to ghtdak/pycoin that referenced this issue Jul 16, 2016
Fix richardkiss#85. Pass netcodes parameter through to subcall.
[gitreformat yapf-ify (github/ghtdak) on Fri Jul 15 12:51:43 2016]
[from commit: 5ebd6c0]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants