Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in pir_to_pics #92

Closed
richelbilderbeek opened this issue Feb 25, 2020 · 6 comments
Closed

Fix bug in pir_to_pics #92

richelbilderbeek opened this issue Feb 25, 2020 · 6 comments
Assignees
@richelbilderbeek
Labels
medium priority Do these after the high priority Issues
Projects
Second version

Comments

@richelbilderbeek
Copy link
Owner

From the Travis CI build log:

Error in FUN(X[[i]], ...) : object 'error' not found
Calls: pir_to_pics ... <Anonymous> -> f -> scales_add_defaults -> lapply -> FUN
Execution halted
@richelbilderbeek richelbilderbeek self-assigned this Feb 25, 2020
@richelbilderbeek richelbilderbeek added this to To do in Second version via automation Feb 25, 2020
@richelbilderbeek richelbilderbeek added the medium priority Do these after the high priority Issues label Feb 25, 2020
@richelbilderbeek richelbilderbeek moved this from To do to In progress in Second version Feb 25, 2020
@richelbilderbeek
Copy link
Owner Author

OK, something happened to pirouette between 2 and 3 days ago:

@richelbilderbeek
Copy link
Owner Author

Weird, all I did those days was using newer version of beastier, beautier, babette, etc... 😕

richelbilderbeek pushed a commit to richelbilderbeek/pirouette that referenced this issue Feb 25, 2020
Increase tests in 'pir_to_pics', progress richelbilderbeek/pirouette_…
d3ca4a3 
…article#92
@richelbilderbeek
Copy link
Owner Author

richelbilderbeek commented Feb 25, 2020 •
edited
Loading

Gotcha (in the Travis build logs)!

@richelbilderbeek
Copy link
Owner Author

Ah, the experiments are not checked to have different filenames:

> pir_params$experiments[[1]]$errors_filename
[1] "/home/richel/temp/temp/pirouette_example_30/example_30_314/errors.csv"
> pir_params$experiments[[2]]$errors_filename
[1] "/home/richel/temp/temp/pirouette_example_30/example_30_314/errors.csv"

@richelbilderbeek
Copy link
Owner Author

Also, df_errors does not contain an x column.

    csv_filename <- first_experiment$errors_filename
    testthat::expect_true(file.exists(csv_filename))
    df_errors <- utils::read.csv(csv_filename)
    testthat::expect_true("x" %in% names(df_errors))
> df_errors
  tree inference_model inference_model_weight site_model clock_model  tree_prior    error_1
1 true      generative                     NA       JC69      strict        yule 0.31887031
2 true       candidate              0.9375251       JC69      strict birth_death 0.31887031
3 twin      generative                     NA       JC69      strict        yule 0.09862447
4 twin       candidate              0.4727861       JC69      strict birth_death 0.09862447
      error_2    error_3     error_4
1 0.060040025 0.01627043 0.042882867
2 0.019009408 0.01266966 0.025718688
3 0.007670674 0.01793261 0.014001079
4 0.021105273 0.03824056 0.007614701

@richelbilderbeek
Copy link
Owner Author

Moved to richelbilderbeek/pirouette#402, closing this one

Second version automation moved this from In progress to Done Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richelbilderbeek richelbilderbeek

Labels
medium priority Do these after the high priority Issues
Projects
No open projects
Second version
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richelbilderbeek