Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies system #57

Merged
merged 11 commits into from
May 18, 2023
Merged

Remove dependencies system #57

merged 11 commits into from
May 18, 2023

Conversation

richibrics
Copy link
Owner

As described in #31 by @infeeeee

@richibrics richibrics linked an issue Feb 16, 2023 that may be closed by this pull request
@richibrics richibrics marked this pull request as ready for review February 17, 2023 10:08
@richibrics
Copy link
Owner Author

This seems okay and ready to be merged, what do you think @infeeeee ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file used anywhere? I can't find any lines opening it, maybe this just remained from PyMonitorMQTT?

Copy link
Collaborator

@infeeeee infeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

My comment on Cpu/settings.yaml is not related to this PR.

@richibrics
Copy link
Owner Author

Okay I tested it and it works 🚀

@richibrics richibrics merged commit e31d98a into main May 18, 2023
@richibrics richibrics deleted the remove-dependencies branch May 18, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink how entity dependencies work
2 participants