Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the dependency system currently doesn't make a lot of sense, as all 'base' entities (
de
andos
)are just providing static values. Simply using a module to collect those values makes maintaining the project much easier.I didn't touch the current dependency system, I just modified the entities. But this fork is working, except for the
Notify
entity. (I didn't modify that because of #28 )If this is accepted, the dependency related functions can be removed from
EntityManager
and from the configurator.If this is accepted, the
SystemConsts
module can be merged with theMyApp
module, making maintaining even more easier.Related to #30
What do you think @richibrics ? Should I continue working on this, or the dependency chain management is the way to go?
I've already written some code about better de detection on linux, but I want this to be settled first: main...infeeeee:IoTuring:desktop-environment