Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate css with pygments 2.2.0, add makefile, update readme #14

Merged
merged 3 commits into from Mar 30, 2017
Merged

Conversation

cs01
Copy link
Contributor

@cs01 cs01 commented Mar 12, 2017

No description provided.

@ghost
Copy link

ghost commented Mar 28, 2017

Removal of the .codehilite class makes it difficult to see what's changed, such as the addition of the /* Comment.Hashbang */ among several others. There's some conversation happening in #6 regarding the wrapper class used. Regardless, the Makefile in this PR will save people time. 😅

@cs01
Copy link
Contributor Author

cs01 commented Mar 29, 2017

Thanks I'll add the class back in. I doubt the pr will ever be merged though since #6 has been open for two years now, but it's worth a shot.

@ghost
Copy link

ghost commented Mar 29, 2017

Hey, either way it'll help :) Seeing your diffs helped me make this already: https://github.com/comfusion/atom-one-pygments

@cs01
Copy link
Contributor Author

cs01 commented Mar 29, 2017

commit 146834e addresses #6

@ghost
Copy link

ghost commented Mar 29, 2017

@richleland would you do the honors? Many many websites are turning to JS for highlighting as a result of #6

@cs01
Copy link
Contributor Author

cs01 commented Mar 29, 2017

They can also just use my fork :) https://github.com/cs01/pygments-css. I'm an active github user and respond quickly to updates.

But I agree with @jhabdas, @richleland, this repo is widely used but out of date. If you no longer want to maintain it, pass the torch on to someone who will.

@richleland richleland merged commit c39da1d into richleland:master Mar 30, 2017
@richleland
Copy link
Owner

Thanks for submitting @cs01. To be honest I wasn't aware it was used widely - I haven't done anything with pygments in years or worked on anything using it. Issues (4 in 8 years) and PRs (the last coming in Oct 2015) have been rare for the repo, so I don't keep as close an eye on it, but happy to keep closer watch moving forward.

Thanks again for the PR and nudging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants