Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postgres ssl connection options #117

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

addnab
Copy link
Contributor

@addnab addnab commented Oct 10, 2020

SSL connection options aren't passed through to the pg.Client if config.connectionString is present.

Example:-
If Postgrator is initialized like so

const postgrator = new Postgrator({
  driver: 'pg',
  migrationDirectory: `...`,
  connectionString: "postgres://...",
  ssl: {
    rejectUnauthorized: false
  }
});

then the pg.Client is not initialized with the ssl options.

Since config.connectionString is accepted by pg.Client, this change should be backward compatible.

@addnab
Copy link
Contributor Author

addnab commented Oct 28, 2020

@rickbergfalk Can you review and publish this please?

@rickbergfalk
Copy link
Owner

Sorry I missed this @addnab will publish shortly

@rickbergfalk rickbergfalk merged commit f1e86b8 into rickbergfalk:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants