Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with Conda install instructions #33

Merged
merged 6 commits into from
Oct 9, 2018

Conversation

chimeworld
Copy link
Contributor

No description provided.

@ricklupton
Copy link
Owner

Hi @ali-alsabbah, thanks for the pull request. This doesn't seem to include your new conda meta file. Can you commit that to your fork as well?

(working on #28)

@ricklupton
Copy link
Owner

Thanks for the update. Do you want to do more work on this? This is already a very useful start; the other things that I think are needed are:

  1. Update the developer docs to explain what steps you did to build and publish a new version of the package to conda
  2. Add post-link and pre-unlink scripts (see example of ipyleaflet) to automatically enable/disable the nbextension when installing -- this would be very helpful as it's a common thing that people miss when installing using pip
  3. Add yourself to the list of contributors in the README (currently empty for this project, see example in floweaver)
  4. Add a note to the changelog in the README that ipysankeywidget can now be installed using conda

If you can continue working on this that would be great, just let me know.

@chimeworld
Copy link
Contributor Author

I think I've just finished 1, 3, and 4. I don't know how to do 2 at the moment, but I will look into it in the coming days.

As for anaconda package ownership, I couldn't transfer ownership to you, but there are a few option:

  • Let it be with the username -big_cake
  • I could delete the package and create a new Anaconda account and update it with my real name
  • I could send you the files and a bash script to upload them yourself using your own account, you would have to modify the script slightly depending on where you place your files.

@ricklupton
Copy link
Owner

Thanks. I think the third option would be best, as the process will have to be repeated by me or someone else whenever a new version is released.

@chimeworld
Copy link
Contributor Author

chimeworld commented Aug 6, 2018 via email

@chimeworld
Copy link
Contributor Author

@ricklupton wondering if there's anything else that needs to be done here

@ricklupton
Copy link
Owner

Hi @ali-alsabbah, sorry for the slow reply. The key thing I'm missing is instructions and/or bash script of how to use your nice new meta.yaml file to build the package and upload it to anaconda! Is it just a matter of running conda build or similar?

Point 2 above (post-link and pre-unlink scripts) is nice to have but can always be added later if you don't have time to figure that out now.

Thanks

@chimeworld
Copy link
Contributor Author

The instruction are here, how do you want me to include them?

https://conda.io/docs/user-guide/tutorials/build-pkgs-skeleton.html

@ricklupton
Copy link
Owner

Adding a section to the developer docs with the steps (or just a link to that webpage) would be great thanks.

Added Conda build instructions
@chimeworld
Copy link
Contributor Author

I believe it should be ready now

@ricklupton ricklupton merged commit 49e5987 into ricklupton:master Oct 9, 2018
@ricklupton
Copy link
Owner

@ali-alsabbah Great, thanks for your help and sticking with it for so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants